Add directory support on CLI #14
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
commented
Apr 18, 2020
src/coverage/inject/cli.cr
Outdated
| end | ||
| end | ||
| end | ||
|
|
||
| raise "You must choose a file to compile" unless filenames.any? | ||
| raise "You must choose at least one file to compile" unless targets.any? |
There was a problem hiding this comment.
@anykeyh Maybe just printing this phrase is enough. Do you think it really have to be an Exception?
There was a problem hiding this comment.
We might use the new Log module to raise an Error message and exit the application instead?
There was a problem hiding this comment.
That's a good idea! I'll update it
There was a problem hiding this comment.
@anykeyh what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to pass directories to the CLI. I added a little
-h --helpoption too